Closed Bug 1931901 Opened 7 months ago Closed 6 months ago

Remove legacy telemetry scalar APIs

Categories

(Toolkit :: Telemetry, task)

Product:
Toolkit
Component:
Telemetry
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
135 Branch
Tracking Flags:
Tracking Status
firefox135 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

(Whiteboard: [fog-migration])

Attachments

(3 files)

Bug 1931901 - remove scriptable APIs to set legacy telemetry scalars and all setMaximum APIs, r=chutten.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1931901 - remove scalar C++ API, r=chutten.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1931901 - remove leftover test references to legacy scalar APIs, r=chutten.
48 bytes, text/x-phabricator-request
Details | Review

Legacy telemetry scalars are now all using the Glean APIs with GIFFT mirrors (bug 1923028, bug 1927093).
The last few callers of the scalar APIs are being removed (bug 1930196, bug 1715258).

After that the remaining use of scalar is either GIFFT or tests. We can make these use the functions declared in TelemetryScalar.h directly instead of exposing an API in nsITelemetry/Telemetry.h.

setMaximum can also be completely removed.

Depends on: 1923028, 1927093, 1930196, 1715258

Depends on D229364

Depends on: 1932090
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/54d0cd358eea remove scriptable APIs to set legacy telemetry scalars and all setMaximum APIs, r=chutten. https://hg.mozilla.org/integration/autoland/rev/f6b042d46afc remove scalar C++ API, r=chutten.

Backed out for causing build bustages in TelemetryScalar.cpp.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/toolkit/components/telemetry/core/TelemetryScalar.cpp:832:14: error: '{anonymous}::ScalarResult {anonymous}::KeyedScalar::AddValue(const StaticMutexAutoLock&, const nsAString&, nsIVariant*)' defined but not used [-Werror=unused-function]
Flags: needinfo?(florian)

(In reply to Serban Stanca [:SerbanS] from comment #5)

Backed out for causing build bustages in TelemetryScalar.cpp.
KeyedScalar::AddValue(const StaticMutexAutoLock&, const nsAString&, nsIVariant*)' defined but not used [-Werror=unused-function]

It's unfortunate that this wasn't caught on try, but it's a good catch, gives me an opportunity to remove an extra 111 lines of code we no longer need.

Flags: needinfo?(florian)
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/26eab75bf7ee remove scriptable APIs to set legacy telemetry scalars and all setMaximum APIs, r=chutten. https://hg.mozilla.org/integration/autoland/rev/b4112ad17888 remove scalar C++ API, r=chutten.

https://hg.mozilla.org/mozilla-central/rev/26eab75bf7ee
https://hg.mozilla.org/mozilla-central/rev/b4112ad17888

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox135: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/39846404e768 remove leftover test references to legacy scalar APIs, r=chutten,geckoview-reviewers,extension-reviewers,home-newtab-reviewers,robwu,ohall,mconley.
See Also: → 1934350
Duplicate of this bug: 1934350
Whiteboard: [fog-migration]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: